Closed jherland closed 6 months ago
@mknorps: Thanks to your comments, and having had some time away from this PR, I've realized that this PR is trying to do too much in one go, specifically:
respect-gitignore
setting, I found two things:
~/.config/git/ignore
), nor did I auto-detect/parse .gitignore
and .ignore
files found further inside the project. Really, this cannot be solved with a static .exclude_from
set of paths, instead I think we need to detect/parse these files while we are traversing the project structure.respect-gitignore
boolean option is a much more user-friendly way to expose this functionality to the user (rather than manipulating sets of paths). Also, using a simple boolean option frees us up to write a proper implementation for the problems described in (a), rather than somehow trying to combine this into .exclude_from
.--exclude-from
should default to the empty set. This ends up simplifying this PR, but adding/implementing the respect-gitignore
boolean option will have to be done in a later PR. 🤷🏻♂️
Commits:
dir_traversal
: AddDirectoryTraversal.exclude_from()
Settings
: Add.exclude_from
, paths containing exclude patternstest_sample_projects
: Run experiments from within the project dirtest_sample_projects
: Addexclude_from
testsdir_traversal
: Prioritize.exclude
rules over.exclude_from
rules--exclude-from
option to CLI