tweag / HaskellR

The full power of R in Haskell.
https://tweag.github.io/HaskellR
Other
584 stars 47 forks source link

Add missing collectAntis.R to extra-source-files #383

Closed bezirg closed 1 year ago

bezirg commented 1 year ago

Building this library by itself (locally by cabal build inside the repo) does not yield to issues, but when building the library as a dependency (e.g. using cabal's source-repository-package) leads to this cabal error:

[31 of 34] Compiling Language.R.QQ    ( src/Language/R/QQ.hs, dist/build/Language/R/QQ.o, dist/build/Language/R/QQ.dyn_o )

src/Language/R/QQ.hs:138:9: error:
    • Exception when trying to run compile-time code:
        R/collectAntis.R: openFile: does not exist (No such file or directory)
      Code: quoteExp Heredoc.there "R/collectAntis.R"
    • In the quasi-quotation: [Heredoc.there|R/collectAntis.R|]
    |
138 |         [Heredoc.there|R/collectAntis.R|]
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

This patch fixes it by adding a missing R file in extra-source-files. Credits goes to @michaelpj for finding the problem out.

bezirg commented 1 year ago

I forgot to mention the error happens on master, with R 4.2 and ghc 9.2.4

mboes commented 1 year ago

Thanks!