search

tweag / HaskellR

The full power of R in Haskell.
https://tweag.github.io/HaskellR
Other
584 stars 47 forks source link

Bumps for GHC 9.8, fix building with unix-2.8, update CI #420

Closed andreasabel closed 8 months ago

andreasabel commented 11 months ago

Triggered by:

facundominguez commented 11 months ago

Hello @andreasabel! Thanks for your patch. I guess some fiddling with the CI configuration is going to be necessary to get this PR in mergeable form. Someone will pick it up eventually if you don't get to it first.

andreasabel commented 11 months ago

@facundominguez Yeah, I usually fix CIs, but none that involve nix because I know nothing about nix.

ConnorBaker commented 10 months ago

So sorry you're running into this issue with CI! I definitely let it go too long without an update.

I've started work to fix that in https://github.com/tweag/HaskellR/pull/422. I hope to get it merged soon.

Depending on how much bandwidth you have, you can rebase once that happens (should mostly involve just removing the changes you had to make to CI) or I can edit it and commit for you. Let me know which you prefer!

andreasabel commented 10 months ago

@ConnorBaker Thanks for taking up the fight with the CI. I suppose after your PR has been merged, a maintainer can merge mine, resolving the conflicts.

ConnorBaker commented 8 months ago

Closing in favor of #422 and #423.

@andreasabel would you make sure those fix the issues you found? Barring GitHub timeout errors, CI should be green for both of those PRs, including the testing on the nightly Stackage snapshot introduced in #423.

andreasabel commented 8 months ago

@ConnorBaker thanks!

cabal build -w ghc-9.8.1 of inline-r from master went fine.
cabal test reports an error:

Test suite test-shootout: RUNNING...
During startup - Warning messages:
1: Setting LC_COLLATE failed, using "C" 
2: Setting LC_TIME failed, using "C" 
3: Setting LC_MESSAGES failed, using "C" 
4: Setting LC_MONETARY failed, using "C" 
During startup - Warning messages:
1: Setting LC_COLLATE failed, using "C" 
2: Setting LC_TIME failed, using "C" 
3: Setting LC_MESSAGES failed, using "C" 
4: Setting LC_MONETARY failed, using "C" 
During startup - Warning messages:
1: Setting LC_COLLATE failed, using "C" 
2: Setting LC_TIME failed, using "C" 
3: Setting LC_MESSAGES failed, using "C" 
4: Setting LC_MONETARY failed, using "C" 
Quoted shootout programs
  tests/shootout/binarytrees.R:       During startup - Warning messages:
1: Setting LC_COLLATE failed, using "C" 
2: Setting LC_TIME failed, using "C" 
3: Setting LC_MESSAGES failed, using "C" 
4: Setting LC_MONETARY failed, using "C" 
Test suite test-shootout: FAIL

Not sure whether you want to fix this. Anyway, once you release to Hackage you can enable inline-r in Stackage again.

ConnorBaker commented 8 months ago

Huh, I'm unable to reproduce on my desktop -- though I am using NixOS and ran

nix-shell ./shell-cabal.nix -I nixpkgs=nixpkgs.nix --run "cabal test all"

How are your cabal and ghc provisioned? Also, is your LANG environment variable set to anything?

EDIT: Also, what version of R do you have? That, and the version of glibc please!

andreasabel commented 8 months ago

Have cabal and ghc (which is ghc-9.8.1) in the PATH.

$ echo $LANG

$ R --version
R version 4.3.2 (2023-10-31) -- "Eye Holes"

I am on macOS 12, not clear how to get the version of glibc there...

ConnorBaker commented 8 months ago

Can you try using an older version of R, from the 4.2.x series? I think there may have been a change in 4.3.x which broke some interop.

andreasabel commented 8 months ago

Mmh, brew does not offer a formula for R@4.2.3 or similar, and it is a bit much hassle to do a manual install. (After all, I am not really a user of R...)