search

tweag / clodl

Turn dynamically linked ELF binaries and libraries into self-contained closures.
BSD 3-Clause "New" or "Revised" License
164 stars 6 forks source link

Fix the mtime of all files in the zip archive #28

Closed thufschmitt closed 5 years ago

thufschmitt commented 5 years ago

Needed to make it reproducible (because the mtime of the files will be included in the archive) In particular, not doing this means that clodl won't play well with the bazel remote cache.

facundominguez commented 5 years ago

Please, reopen this if -X doesn't do it.

thufschmitt commented 5 years ago

@facundominguez didn't notice that you closed this instead of merging it (our repo was still pointing at a fork until recently so we had the fix in our version). Any reason for not merging it now that it uses -X instead of the contrieved logic I had before?

If that's OK I'm gonna open a new PR for that (can't open that one again because the branch has been deleted)

facundominguez commented 5 years ago

I think I closed it because I didn't notice the update to -X. Excuse me for the mishap. I'm fine merging it.

thufschmitt commented 5 years ago

Awesome, thanks