search

tweag / clodl

Turn dynamically linked ELF binaries and libraries into self-contained closures.
BSD 3-Clause "New" or "Revised" License
170 stars 6 forks source link

Running the project with Bazel 7.2.0 results in untracked files #53

Open hofbi opened 3 months ago

hofbi commented 3 months ago

Describe the bug

When I run bazel build //... with bazel 7.2.0 (should be any bazel 7+), bazel creates MODULE.bazel and MODULE.bazel.lock. Same for the tests.

What should we do with these files

  1. Commit them to the repo
  2. Add them to .gitignore until you migrate to bzlmod
aherrmann commented 3 months ago

Indeed, clodl has not yet been upgraded to support bzlmod, yet. Do the files that Bazel generates work? A contribution to updgrade clodl to bzlmod would be very welcome.

hofbi commented 3 months ago

Kind of... The MODULE.bazel file just contains

###############################################################################
# Bazel now uses Bzlmod by default to manage external dependencies.
# Please consider migrating your external dependencies from WORKSPACE to MODULE.bazel.
#
# For more details, please check https://github.com/bazelbuild/bazel/issues/18958
###############################################################################

The MODULE.bazel.lock file contains some actual content but there was (maybe it is resolved meanwhile) an issue so many people ignore this file.

But I also encounter https://github.com/tweag/clodl/issues/54