search

tweag / cooked-validators

MIT License
39 stars 11 forks source link

Document the double satisfaction vulnerability in the auction contract #177

Closed carlhammann closed 1 year ago

carlhammann commented 1 year ago

This PR documents and exploits the double satisfaction vulnerability found by Facundo. It also removes the doubleSatAttack in the tests for the auction contract: It is possible, but not straightforward to make it find this particular vulnerability, and an automatic doubleSatAttack that needs a lot manual of work to find a relatively simple vulnerability doesn't look too compelling.

carlhammann commented 1 year ago

For the record: As far as I understand it, the doubleSatAttack performs poorly on this example not because of some flaw in that function itself, but for more general design reasons in cooked-validators.