search

tweag / cooked-validators

MIT License
39 stars 11 forks source link

Update `ormolu` #244

Closed florentc closed 1 year ago

florentc commented 1 year ago

The current ormolu version on main is 0.3.1. nixpkgs provides 0.5.0 which should solve an issue we have sometimes where ormolu is not aware of operator precedence and produces a less-than-ideal output. E.g. here with == and &&

Niols commented 1 year ago

Note that it is nixpkgs unstable that provides 0.5.0. But we might still decide it's worth changing in our configuration. @gabrielhdt WDYT?

gabrielhdt commented 1 year ago

I think we can drop the 22.11 constraint in the flake and track unstable. We may want to put a commit back when there's a release.

Niols commented 1 year ago

Note that this is quite relevant because the version of HLS in our flake uses Ormolu 0.5. This means that people see a discrepancy between what happens in their IDE and what happens in the terminal, the pre-commit hooks and the CI. (At least these last three are consistent.)