search

tweag / cooked-validators

MIT License
39 stars 11 forks source link

Fix an off-by-one mistake #360

Closed carlhammann closed 11 months ago

carlhammann commented 11 months ago

In PR #354, I introduced a mechanism that counts how many times a given datum is present in the MockChain, and only deletes the entry in the 'mcstDatums' once that count reaches zero. I realized just now that I wrote the logic in such a way as to delete the entry after the count has reached zero and would be decremented to -1. This means that entries are never deleted, which defeats the memory saving purpose that of the whole operation... This commit rectifies this.

CI is failing at the moment, because of the problem that #359 will fix.

Niols commented 11 months ago

CI is failing at the moment, because of the problem that https://github.com/tweag/cooked-validators/pull/359 will fix.

Shouldn't this PR then target the corresponding branch?

carlhammann commented 11 months ago

Shouldn't this PR then target the corresponding branch?

Indeed!