search

tweag / cybersourcery

UNMAINTAINED. A pain removal gem for working with Cybersource Secure Acceptance Silent Order POST
MIT License
7 stars 9 forks source link

Poltergeist/PhantomJS #3

Closed justincampbell closed 10 years ago

justincampbell commented 10 years ago

@toppa This seems to work, but I see 3 specs failing around client-side validation. Were these passing before? I can't get Selenium to work on Yosemite.

Either way, I think headless tests would make the test suite nicer.

toppa commented 10 years ago

Thanks Justin. The specs were passing before. There are javascript dependencies for the feature specs, which is why I'm using Selenium. See here

The main thing is that the required format for the expiration date is not very user friendly as an input field (MM-YYYY), so the form I have is using select fields for the month and date, and then uses the selections to populate a hidden input in the required format.

It's definitely possible to make a version of the form that doesn't require JS, but for the demo, I wanted to include some bells and whistles for people to use if they want.

toppa commented 10 years ago

Ok... I should have checked first. Poltergeist should run the JS. So I don't know why the specs are now failing with Poltergeist. I'll take a look.

toppa commented 10 years ago

It's working now. Your code was fine, and the suite runs faster now. Thanks! it was a documentation problem. I've added a section to the readme saying that you need to start the proxy server for the feature tests to pass.

It's also a bit of an architectural problem. You need the gem with its development dependencies in order to also get the testing gem, as the proxy server is a feature of the testing gem (we made a separate gem for it, as we didn't want to assume people would necessarily want all our testing infrastructure). So you can't run all the tests successfully without the development dependencies.

justincampbell commented 10 years ago

Thanks!