search

tweag / ghc

Fork of official GHC repository.
http://www.haskell.org/ghc/
Other
44 stars 5 forks source link

Parse qualified do statements #477

Closed Tritlo closed 4 years ago

Tritlo commented 4 years ago

This implements the parser, and makes the module name available for the AST constructors DoExpr and MDoExpr. I have checked that it builds and parses a few trivial examples, but more rigorous tests are required.

facundominguez commented 4 years ago

I squashed two of the commits.

Tritlo commented 4 years ago

I think it would be better to have it all within the tweag org, since it'll likely be easier to push for a merge from tweag to haddock later

On Fri, 22 May 2020 at 14:59, Facundo Domínguez notifications@github.com wrote:

@facundominguez commented on this pull request.

In compiler/GHC/Parser/Lexer.x https://github.com/tweag/ghc/pull/477#discussion_r429231076:

  • | ITqdo FastString
  • | ITqmdo FastString

Thanks Arnaud. I saw this comment after merging. Did these instructions with a new fork I made of my own. Could change it to tweag's if it has any relevance.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tweag/ghc/pull/477#discussion_r429231076, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMXBV57CZK3BP4LGMF7XUTRSZZK3ANCNFSM4NGGXSKA .

-- Bestu Kveðjur/Best regards, Matthías Páll Gissurarson.

facundominguez commented 4 years ago

I updated the submodule to point to tweag's repo. And force-pushed the qualified-do branch.