search

tweag / jupyenv

Declarative and reproducible Jupyter environments - powered by Nix
https://jupyenv.io/
MIT License
666 stars 137 forks source link

Python: add ignoreCollisions argument #390

Closed GTrunSec closed 1 year ago

GTrunSec commented 1 year ago

This PR from https://github.com/tweag/jupyterWith/pull/88, is also necessary for the current branch. yes, It has a little bit risky, if you want to use the nixpkgs.pythn3Pckages in the poetry env.

djacu commented 1 year ago

Hey @GTrunSec

Thanks for the PR!

I haven't tested this to verify it works but the end of this section indicates that ignoreCollisions ins't compatible with python.withPackages which mkPoetryEnv uses. Have you tested this?

GTrunSec commented 1 year ago

https://github.com/GTrunSec/DeSci/blob/layers/nix/python/packages/overrides.nix#L9 I have tested that case,and worked well with nixpkgs and poetry. especially for the pytorch or tensorflow. You know that it would be tough to override them into portryEnv.

djacu commented 1 year ago

Thanks for the contribution @GTrunSec! Sorry it took so long to merge.