Open github-actions[bot] opened 1 year ago
Name | Link |
---|---|
Latest commit | 4d7adbcbb8dcbd11b803f6dbc04a16d1badd8ca0 |
Latest deploy log | https://app.netlify.com/sites/tweag-jupyterwith/deploys/66f89b4f7d1d1200088dc3e6 |
Deploy Preview | https://deploy-preview-418--tweag-jupyterwith.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
I tried pinning the version of ocaml-system
in the ocaml module.nix file like so
ocamlPackages = lib.mkOption {
type = types.attrs;
default = { ocaml-system = "4.14.1"; };
example = lib.literalExpression ''
{
hex = "*";
owl = "*";
}
'';
description = lib.mdDoc ''
Attribute set of user desired OCaml packages.
'';
};
but it didn't fix the issue
resolve> [ERROR] No solution including optional dependencies for jupyter.dev & merlin & ocaml-system.4.14.1: * Missing dependency:
resolve> - ocaml-system >= 4.14.1
resolve> no matching version
error: builder for '/nix/store/xj0w474ymn6xdgqr9ckxl2grlw30v7zh-resolve.drv' failed with exit code 20;
last 5 log lines:
> [ERROR] No solution including optional dependencies for jupyter.dev & merlin & ocaml-system.4.14.1: * Missing dependency:
> - ocaml-system >= 4.14.1
> no matching version
>
>
For full logs, run 'nix log /nix/store/xj0w474ymn6xdgqr9ckxl2grlw30v7zh-resolve.drv'.
(use '--show-trace' to show detailed location information)
I also tried bumping the version of the ocaml jupyter
package in the default.nix file like so
scope = let
name = "jupyter";
version = "2.8.2";
src = pkgs.fetchFromGitHub {
owner = "akabe";
repo = "ocaml-jupyter";
rev = "v${version}";
sha256 = "sha256-wy5Fn4wrSdNVczXlm4eelb445vWs7itdiMv166XJA/8=";
};
but that didn't fix it either.
error: builder for '/nix/store/xb58ssjw2c84g5z8a9armqvhg75sh9rj-resolve.drv' failed with exit code 20;
last 5 log lines:
> [ERROR] No solution including optional dependencies for jupyter.dev & merlin & ocaml-system.4.14.1: * Missing dependency:
> - ocaml-system >= 4.14.1
> no matching version
>
>
For full logs, run 'nix log /nix/store/xb58ssjw2c84g5z8a9armqvhg75sh9rj-resolve.drv'.
(use '--show-trace' to show detailed location information)
Seems like version 2.8.1 should have fixed this.
Is there any particular reason you want to use ocaml-system
(from nixpkgs) rather than ocaml-base-compiler
(from opam-repository
)?
With this patch, the example builds:
diff --git a/modules/kernels/ocaml/default.nix b/modules/kernels/ocaml/default.nix
index 6b4f995..049a4ee 100644
--- a/modules/kernels/ocaml/default.nix
+++ b/modules/kernels/ocaml/default.nix
@@ -10,7 +10,7 @@
# https://github.com/tweag/opam-nix
opam-nix ? self.inputs.opam-nix,
# Set of required packages
- requiredOcamlPackages ? {merlin = "*";},
+ requiredOcamlPackages,
# Set of user desired packages
ocamlPackages ? {}, # { hex = "*"; owl = "*"; },
# List of directories containing .opam files
diff --git a/modules/kernels/ocaml/module.nix b/modules/kernels/ocaml/module.nix
index 9202b09..b00c110 100644
--- a/modules/kernels/ocaml/module.nix
+++ b/modules/kernels/ocaml/module.nix
@@ -30,12 +30,9 @@
requiredOcamlPackages = lib.mkOption {
type = types.attrs;
- default = {merlin = "*";};
- defaultText = lib.literalExpression ''
- { merlin = "*"; }
- '';
+ default = { merlin = "*"; ocaml-base-compiler = "4.14.0"; };
example = lib.literalExpression ''
- { merlin = "4.7.1-500"; }
+ { merlin = "4.7.1-500"; ocaml-system = "4.14.1"; }
'';
description = lib.mdDoc ''
Attribute set of required OCaml packages.
FTR, the issue is due to an old version of opam-repository
pinned in opam-nix
. I'll update it now, and after that update just ocaml-system = "4.14.1"
should work.
Is there any particular reason you want to use
ocaml-system
(from nixpkgs) rather thanocaml-base-compiler
(fromopam-repository
)?
I thought we were using the opam repository. I'd prefer to let opam-nix handle the dependencies at all times if possible and it makes sense.
Automated changes by the update-flake-lock GitHub Action.
Running GitHub Actions on this PR
GitHub Actions will not run workflows on pull requests which are opened by a GitHub Action.
To run GitHub Actions workflows on this PR, run: