tweag / jupyenv

Declarative and reproducible Jupyter environments - powered by Nix
https://jupyenv.io/
MIT License
666 stars 137 forks source link

refactor/clean-up-codebase #437

Closed djacu closed 1 year ago

djacu commented 1 year ago

Removes unused functions from flake.nix. Much of the functionality happened in let in blocks and was extracted into functions that can be called. Libraries were created so functions can be organized. Functions were documented with examples. The library has been exposed as a flake output for easy development and debugging.

netlify[bot] commented 1 year ago

Deploy Preview for tweag-jupyterwith ready!

Name Link
Latest commit efe0d06cb75abe4eda9ed54932b1b17729148b35
Latest deploy log https://app.netlify.com/sites/tweag-jupyterwith/deploys/64011932968d730008cad816
Deploy Preview https://deploy-preview-437--tweag-jupyterwith.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

github-actions[bot] commented 1 year ago

🚀 Deployed on https://63ef0cbd6ab7ad22109fb09a--tweag-jupyterwith.netlify.app

github-actions[bot] commented 1 year ago

🚀 Deployed on https://63f05bdb5be079463d9467d8--tweag-jupyterwith.netlify.app

github-actions[bot] commented 1 year ago

🚀 Deployed on https://63f06f2b565a835111a09460--tweag-jupyterwith.netlify.app

github-actions[bot] commented 1 year ago

🚀 Deployed on https://63f6de68ab1d45482eefa534--tweag-jupyterwith.netlify.app

github-actions[bot] commented 1 year ago

🚀 Deployed on https://63f9a4210e38c155319d70fc--tweag-jupyterwith.netlify.app

github-actions[bot] commented 1 year ago

🚀 Deployed on https://63ff018bb6fea64280e8c6f3--tweag-jupyterwith.netlify.app

github-actions[bot] commented 1 year ago

🚀 Deployed on https://63ff8e681c233e0b4bc8c887--tweag-jupyterwith.netlify.app

github-actions[bot] commented 1 year ago

🚀 Deployed on https://6400376b93c3fa3c684e104c--tweag-jupyterwith.netlify.app

github-actions[bot] commented 1 year ago

🚀 Deployed on https://640119bb67e11f381cf71f3b--tweag-jupyterwith.netlify.app

github-actions[bot] commented 1 year ago

🚀 Deployed on https://64011a9fca19683e87c7d4bc--tweag-jupyterwith.netlify.app

GTrunSec commented 1 year ago

No special critical here, looks good so far.

I'm going to talk about some motivation for the refactorV2 at another issue.