search

tweag / jupyenv

Declarative and reproducible Jupyter environments - powered by Nix
https://jupyenv.io/
MIT License
666 stars 137 forks source link

refactor/move-kernelfunc #462

Closed djacu closed 1 year ago

djacu commented 1 year ago

Extract kernelFunc to modules/poetry.nix.

netlify[bot] commented 1 year ago

Deploy Preview for tweag-jupyterwith ready!

Name Link
Latest commit 59ed5699433f7a91d9116ce1a20fd74a8a5db4a9
Latest deploy log https://app.netlify.com/sites/tweag-jupyterwith/deploys/6413fe99954d88000828df4d
Deploy Preview https://deploy-preview-462--tweag-jupyterwith.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

github-actions[bot] commented 1 year ago

🚀 Deployed on https://6413ffe63905337157d23224--tweag-jupyterwith.netlify.app

GTrunSec commented 1 year ago

Notice: https://github.com/tweag/jupyenv/pull/450#issuecomment-1455026847, (I don't know why).

my solution: https://github.com/tweag/jupyenv/pull/450/files#diff-8bf585666371b85c4eb513ad2163c69e20eaf72b2faa18abc1a0884c9827d70fR136

Also, I think it is necessary to provide an additional option for poetryEnv, not only the problem of overalys, the most important thing is that pythonEnv can be passed from the outside. (we can simply add a group deps of jupyenv for other poetyEnv , then add it)