search

tweag / jupyenv

Declarative and reproducible Jupyter environments - powered by Nix
https://jupyenv.io/
MIT License
628 stars 131 forks source link

ARM macOS support #496

Closed wokalski closed 9 months ago

wokalski commented 1 year ago

Fixes #388

I was able to run jupyterlab successfully after this change. Let me know if I'm missing anything!

netlify[bot] commented 1 year ago

Deploy Preview for tweag-jupyterwith ready!

Name Link
Latest commit 61dd90d4934c4bbbfbf54f717f284a13ea14e299
Latest deploy log https://app.netlify.com/sites/tweag-jupyterwith/deploys/647b15b310c7cc0008c958c2
Deploy Preview https://deploy-preview-496--tweag-jupyterwith.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

srid commented 1 year ago

Also need to modify the template,

https://github.com/tweag/jupyenv/blob/3ad2c9512c9efd586cf63adde454e734a8ce049c/template/flake.nix#L25-L28

I observe that this project has no CI for macOS? How will macOS support be tested in CI going forward?

richban commented 10 months ago 
➜ nix run
warning: Git tree '/Users/richard.banyi/Developer/nix-project-flakes' is dirty
error: attribute 'aarch64-darwin' missing

       at /nix/store/nvss7vjwjdq6prxfwf24swzksn4f6cvm-source/jupyenv/flake.nix:32:18:

           31|       system: let
           32|         inherit (jupyenv.lib.${system}) mkJupyterlabNew;
             |                  ^
           33|         jupyterlab = mkJupyterlabNew ({...}: {
(use '--show-trace' to show detailed location information)
srid commented 9 months ago

Ping.

Can we get this PR merged?

GTrunSec commented 9 months ago

Could you re-submit the commits to adding these systems? @wokalski 

  systems = [
        "x86_64-linux"
        "x86_64-darwin"
        "aarch64-linux"
        "aarch64-darwin"
      ];
wokalski commented 9 months ago

Sorry. I ended up not using it so i dont have interest working on this.

GTrunSec commented 9 months ago

it's ok, im going to refactor the jupyenv on this weekend.