Use custom stream of trees type in lazy sampler

tweag / monad-bayes

A library for probabilistic programming in Haskell.

MIT License

410 stars 62 forks source link

Closed turion closed 2 years ago

turion commented 2 years ago

Fixes #184

netlify[bot] commented 2 years ago

Name	Link
Latest commit	85bbd1494c87971df15d5b8bd2506cb79e833275
Latest deploy log	https://app.netlify.com/sites/monad-bayes/deploys/63469665fb225c0008fa7be8
Deploy Preview	https://deploy-preview-211--monad-bayes.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

reubenharry commented 2 years ago

Why not use a library definition of a stream? Unnecessary overhead?

turion commented 2 years ago

Why not use a library definition of a stream? Unnecessary overhead?

Yes, I looked into several libraries. Some were well-built, but complex like https://hackage.haskell.org/package/streaming-0.2.3.1/docs/Streaming.html, some were simple enough like https://hackage.haskell.org/package/streams but seem not active enough to be a reliable dependency.

turion commented 2 years ago

If you want, I can rewrite with streaming. I think that would be my first choice.

turion commented 2 years ago

...but I think that at this point, a dependency would be unnecessary overhead. We're not using any fancy stream manipulation functions (yet).