tweag / monad-bayes

A library for probabilistic programming in Haskell.
MIT License
407 stars 62 forks source link

feature/use new jupyterwith #231

Closed djacu closed 1 year ago

djacu commented 1 year ago

Updated to use the latest version of jupyterWith. ~Still waiting on https://github.com/tweag/jupyterWith/pull/358 to go through so the new iHaskell kernel is available.~ PR is ready for review.

netlify[bot] commented 1 year ago

Deploy Preview for monad-bayes canceled.

Name Link
Latest commit 0a78bc6d3946d3aefce22967b3a5a02e36f11af9
Latest deploy log https://app.netlify.com/sites/monad-bayes/deploys/6388b87c4e1f490008a609dc
netlify[bot] commented 1 year ago

Deploy Preview for monad-bayes-site canceled.

Name Link
Latest commit 0a78bc6d3946d3aefce22967b3a5a02e36f11af9
Latest deploy log https://app.netlify.com/sites/monad-bayes-site/deploys/6388b87c8e308e0009519d48
mknorps commented 1 year ago

@djacu How should you run jupyter lab? I am running jupyter-lab from within the shell and I got a repeated message:

jupyterWith needs to build JupyterLab.
jupyterWith needs to build JupyterLab.
jupyterWith needs to build JupyterLab.
djacu commented 1 year ago

@mknorps sorry I just saw your message. Are you still getting that repeated message?

mknorps commented 1 year ago

@mknorps sorry I just saw your message. Are you still getting that repeated message?

Yes. It looks like similar to https://github.com/tweag/jupyterWith/issues/341.

turion commented 1 year ago

Thanks a lot! Can you rebase, and I'll look into this?

turion commented 1 year ago

I took the liberty to rebase, resolve conflicts, and push force.

turion commented 1 year ago

I have superficially checked that even after the rebase, all changes to flake.lock are additions or updates.

turion commented 1 year ago

The changes to the notebook seem fine.