Refactoring proposal: Reorder tests

[turion]

Right now the structure of tests is:

• One big Spec.hs file that contains half of every test
• Flat collection of modules TestFoo.hs that contain the other half of the tests, but sorted by topic

For example we have in Spec.hs:

  describe "Population" do
    context "controlling population" do
      it "preserves the population when not explicitly altered" do
        popSize <- TestPopulation.popSize
        popSize `shouldBe` 5

And in TestPopulation.hs:

popSize :: IO Int
popSize =
  sampleIOfixed (weightedSampleSize $ spawn 5 >> sprinkler)

To understand whether the test is correct, and also to write a new test, I need to deal with both files and keep them in sync. Also, Spec.hs will grow longer and longer to the point where one has to jump around a lot in the file to search for (halves of) tests.

Proposal

How about refactoring like this:

• Move TestFoo.hs -> Test/Foo.hs
• Test/Foo.hs tests exactly functions from src/Control/Monad/Bayes/Foo.hs
• All tests regarding one module are collected in one describe "Foo" block
• There is a root file Test.hs importing and collecting all those individual tests in one hspec block