search

tweag / monad-bayes

A library for probabilistic programming in Haskell.
MIT License
404 stars 62 forks source link

Warnings as errors #255

Closed turion closed 1 year ago

turion commented 1 year ago

I think it would be a good idea to catch GHC warnings early on. This PR makes sure CI fails when there is a GHC warning.

CC @idontgetoutmuch

turion commented 1 year ago

Naturally, the build fails because there are warnings in the current tree.

idontgetoutmuch commented 1 year ago

@turion can you fix the warning and then resubmit?

turion commented 1 year ago

@idontgetoutmuch can we not merge yet? It would be nice to merge without squashing.

idontgetoutmuch commented 1 year ago

Great! Thanks for doing this.