tweag / monad-bayes

A library for probabilistic programming in Haskell.
MIT License
404 stars 62 forks source link

Make transformer naming idiomatic. Fixes #189. Fixes #242. #295

Closed turion closed 11 months ago

turion commented 1 year ago

CC @reubenharry @idontgetoutmuch . Can you review? I'd like to merge and release (as version 1.2.0) before publishing my blog post, so the blog post can be with the new conventions.

idontgetoutmuch commented 1 year ago

@reubenharry you will have to edit your tutorial maybe? @turion Lint is failing and there are some conflicts.

turion commented 1 year ago

you will have to edit your tutorial maybe?

I tried to take care of this and changed all the md files. I'm assuming this is enough?

Lint is failing and there are some conflicts.

Yes, I can fix that.

turion commented 1 year ago

you will have to edit your tutorial maybe?

I tried to take care of this and changed all the md files. I'm assuming this is enough?

@reubenharry can you clarify whether the files docs/docs/notebook/*.html need to be adapted? Are they autogenerated? If yes, how?

reubenharry commented 1 year ago

To my recollection, they are not autogenerated - I just exported and saved the notebooks manually.

turion commented 1 year ago

Ah, so I need to regenerate them before merging? -- Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.

reubenharry commented 1 year ago

In theory, yes, by manually exporting each and copying it to the appropriate folder. I don't object if you don't though, I know it's a slight hassle.

turion commented 1 year ago

What I haven't understood is whether netlify serves the .html directly, or whether it regenerates them from the .md. If the latter, I'd in fact recommend removing the *.html from the repo. -- Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.

reubenharry commented 1 year ago

For the notebooks or docs? It's been a while, but I think it builds the docs from the md (using mkdocs), but the notebooks go straight from ipynb to html.

turion commented 1 year ago

In theory, yes, by manually exporting each and copying it to the appropriate folder.

I'm trying to do that with jupyter-nbconvert, so far without luck. How do you do that?

turion commented 1 year ago

As far as I understand, the only thing that is not automatic is how the html are generated from the notebooks. It would be good to merge https://github.com/tweag/monad-bayes/pull/302 first to make sure I don't break the documentation.

turion commented 11 months ago

In fact I want to merge https://github.com/tweag/monad-bayes/pull/304 first, which superseded #302.