search

tweag / network-transport-zeromq

ZeroMQ transport for distributed-process (aka Cloud Haskell)
BSD 3-Clause "New" or "Revised" License
22 stars 3 forks source link

Hints #29

Closed qnikst closed 9 years ago

qnikst commented 10 years ago

This commit introduces a new API that can be used for zeromq specific configuration and solving bootstrap problem that exists in n-t-zmq.

Review on Reviewable

mboes commented 10 years ago

@facundominguez could you fixup grammar? And then good to merge I think. Unless you have any reservations.

mboes commented 9 years ago

ping @facundominguez

mboes commented 9 years ago

@qnikst rebase against latest master to pull in CI fixes.

qnikst commented 9 years ago

Rebased, waiting for @facundominguez review.

facundominguez commented 9 years ago

First commit message:

Hints is a special data type that can be provided in order to configure sockets that are created by the user. This type is intended to be used for zeromq specific API.

Second commit message:

With this information, InternalTransport can be used to create new connections as it contains all the parameters passed to the function createTransportExposeInternals.

Third commit:

The following functions are exposed: apiNewEndPoint -- creates a new endpoint with hints apiNewMulticastGroup -- creates a new multicast group

These functions take Hints as an argument and can be used for zeromq-specific configuration.

qnikst commented 9 years ago

I have addressed all comments, I suppose.

facundominguez commented 9 years ago

The function apiNewMulticastGroup is not exported, yet the commit message of 9f36456 does mention it.

You should merge after addressing that. :+1:

qnikst commented 9 years ago

I'm merging this pull request. However issue #30 should be fixed in order to have reliable test suite.