tweag / network-transport-zeromq

ZeroMQ transport for distributed-process (aka Cloud Haskell)
BSD 3-Clause "New" or "Revised" License
22 stars 3 forks source link

Cabal bench #6

Closed qnikst closed 10 years ago

mboes commented 10 years ago

@qnikst what's the difference between *Wrapper and *Run? Their rationale should be explained somewhere.

mboes commented 10 years ago

Also, why do you say forkOS might introduce additional overhead, so long as the benchmark time is taken to start after the forking?

qnikst commented 10 years ago

there is the following difference:

I can add description but what will be an appropriate place?

qnikst commented 10 years ago

forkOS uses one RTS so global GC will block both threads, while in case if we will use real fork or runProcess we will have 2 separate runtimes. I not sure that it will have a big impact on a result, but I have to address it at least in commit message :)

mboes commented 10 years ago

I don't see a need for 3 separate files for each benchmark. What with the difference between 2 of those files not being immediately obvious to the reader, and not readily documentable, the following scheme would be better I think:

qnikst commented 10 years ago

Updated.

mboes commented 10 years ago

Not that I can see. Pushed to right branch?

qnikst commented 10 years ago

No, pushed to qnikst repo. Fixed.

mboes commented 10 years ago

Pushed a fix to the flag name. I noticed in doing so that most benchmarks are actually not disabled from being installed when the flag is off.

That needs to be fixed before this is merged.