tweag / nickel-lang.org

The website of the Nickel language
MIT License
5 stars 3 forks source link

Use Monaco editor instead of Ace? #334

Open matthew-healy opened 1 year ago

matthew-healy commented 1 year ago

Currently the playground uses Ace as its editor UI. In general this seems to work well, but it requires us to maintain custom syntax highlighting code which can become out of sync with the current state of the language (as happened here).

If we were to instead use Microsoft's Monaco editor, we could reuse the language configuration defined in this vscode extension, which should be less likely to get out of sync.

yannham commented 1 year ago

Does Monaco supports LSP? This would be a double-win, because we currently have a kind of proto-LSP built in WASM in order to show errors directly inside the editor. It's obviously much less featured, and yet something else to maintain.

matthew-healy commented 1 year ago

I haven't looked into it in any detail, but the lsp docs seem to suggest that it does.