Rework format.rs to new Topiary API

tweag / nickel

Better configuration for less

https://nickel-lang.org/

MIT License

2.37k stars 89 forks source link

Rework format.rs to new Topiary API #1838

Closed ErinvanderVeen closed 7 months ago

ErinvanderVeen commented 7 months ago

TODO! Wasm-bindgen issue needs to be solved. Which is a pain-point for both Nickel and Topiary alike. We just happen to pin different versions for the same reason.

yannham commented 7 months ago

I've taken over this PR. The wasm-bindgen version is updated to the latest one from Nixpkgs/unstable, which is the one used by Topiary as well.

yannham commented 7 months ago

@vkleen I've disabled the idempotency check in release mode, as after checking with @ErinvanderVeen, an idempotency failure would mean Nickel would refuse to format the codebase, which is unacceptable. We could try first with idempotency, and then re-format without if the check fails, but this starts to be complicated. Let me know if that sounds good to you and if we can proceed with the PR in the current state