search

tweag / nickel

Better configuration for less
https://nickel-lang.org/
MIT License
2.23k stars 85 forks source link

Dedup diagnostics #1883

Closed jneem closed 3 months ago

jneem commented 3 months ago

Unfortunately the lsp_types crate doesn't provide a lot of Ord impls, so I had to write some wrappers. Is there a better way? (Of course we could use hashmaps to dedup, but lsp_types also doesn't provide Hash impls)

Fixes #1882

jneem commented 3 months ago

I had a try with this but it had even a little more boilerplate. It would be fine if the lsp_types types were at the "top level", but the Option<Vec<lsp_types::DiagnosticRelatedInformation>> is pretty annoying...