search

tweag / nickel

Better configuration for less
https://nickel-lang.org/
MIT License
2.23k stars 85 forks source link

chore: add assert to the stdlib #1914

Closed ajbt200128 closed 1 month ago

ajbt200128 commented 1 month ago

Previously Nickel was using an Assert only for integration tests. This pr makes it officially part of the standard library.

Closes https://github.com/tweag/nickel/issues/1300

ajbt200128 commented 1 month ago

Note the original issue recommends adding these to std.test . I can move Assert and check there, and maybe Equal belongs there too. Added it to std.contract for now since Equal is there already

ajbt200128 commented 1 month ago

Looks like pre-commit is failing, must not have run properly on my machine

yannham commented 1 month ago

After some discussions, we chose to put it in a new dedicated module std.test.

yannham commented 1 month ago

So, this PR was delayed for reasons that have nothing to do with the original change (mostly related to our flake being outdated because of unrelated C++ compilations errors for the nix-experimental feature), but I think I can finally proceed now.