tweag / nickel

Better configuration for less
https://nickel-lang.org/
MIT License
2.23k stars 85 forks source link

Add a subsumption rule between record types and dictionary types #1977

Closed Eckaos closed 2 days ago

Eckaos commented 1 week ago

Modified the subsumption function to add the subsumption rule between a record type and a dictionary type.

yannham commented 6 days ago

@Eckaos feel free to re-request a review from me when you think it's ready for a new round!

Eckaos commented 6 days ago

If you think there no need to think about GenericUnifRecordRowsIteratorItem::TailDyn and GenericUnifRecordRowsIteratorItem::TailVar(&'a LocIdent), I think it's ready for a new round ! @yannham

Eckaos commented 6 days ago

@yannham It must be good !