tweag / nickel

Better configuration for less
https://nickel-lang.org/
MIT License
2.43k stars 93 forks source link

Make serde-wasm-bindgen optional in core #2089

Closed akavel closed 2 weeks ago

akavel commented 2 weeks ago

Aiming to reduce the dependencies footprint of nickel-lang-core.

At a glance, it looks like the serde-wasm-bindgen dependency is needed only for the repl-wasm feature. Making it optional and enabled only by this feature should remove some dependencies in a default build.

github-actions[bot] commented 2 weeks ago

🐰 Bencher Report

Branchwasm-feat-fix
Testbedubuntu-latest
Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
fibonacci 10📈 view plot
🚷 view threshold
479,750.00
foldl arrays 50📈 view plot
🚷 view threshold
1,688,200.00
foldl arrays 500📈 view plot
🚷 view threshold
6,736,500.00
foldr strings 50📈 view plot
🚷 view threshold
7,064,000.00
foldr strings 500📈 view plot
🚷 view threshold
61,483,000.00
generate normal 250📈 view plot
🚷 view threshold
42,809,000.00
generate normal 50📈 view plot
🚷 view threshold
1,969,800.00
generate normal unchecked 1000📈 view plot
🚷 view threshold
3,274,600.00
generate normal unchecked 200📈 view plot
🚷 view threshold
752,690.00
pidigits 100📈 view plot
🚷 view threshold
3,150,100.00
pipe normal 20📈 view plot
🚷 view threshold
1,485,000.00
pipe normal 200📈 view plot
🚷 view threshold
9,913,400.00
product 30📈 view plot
🚷 view threshold
824,760.00
scalar 10📈 view plot
🚷 view threshold
1,501,800.00
sum 30📈 view plot
🚷 view threshold
817,210.00
🐰 View full continuous benchmarking report in Bencher