Closed rapenne-s closed 2 years ago
I like the idea a lot. A few considerations for me to also love the implementation:
./bin
and added it to the nix-shell
environment as lab
that way users don't have to know where it lives and have to type less to use itI moved the script to bin/lab
however I don't see how to integrate it in nix-shell
, do you have some hints?
I added some checks making sure:
nix_bazel_codelab
git repositoryI'll take a look at the CI after the script has been refined
Ok, found a way to provide lab
in the $PATH when using nix-shell
I moved the reference WORKSPACE into the new solutions/
directory and deleted the script containing it.
lab
can now be used from anywhere in the git directory and not only the top level.
I forgot to add a paragraph about lab
in the README.md
, @fricklerhandwerk could you review it?
Thanks for your time reviewing my work @fricklerhandwerk
I made a new script
codelab_compare.sh
but the name can be changed, I don't really like it. The solutions have been moved from thegenerate_build_files.sh
to asolutions/
subdirectory.The script provides commands like
diff
,display
,install
andinstall_all
to help you in the exercises toI think it's the best approach so the solutions files are readable and not embedded in a script, the solutions are lying in the same working directory and not in another branch, and it's still interactive without having to replace your work when looking for help.