search

tweag / nix_bazel_codelab

Nix+Bazel Codelab
Apache License 2.0
50 stars 4 forks source link

Broken link in README as ts_proto_library has been removed from rules_nodejs #26

Closed tshaynik closed 2 years ago

tshaynik commented 2 years ago

Describe the bug

The link on line 247 of the README to the ts_proto_library docs goes to a 404. This seems to be because this function has been removed from rules_nodejs, and so when we eventually update rules_nodejs, this will cause the codelab to break.

To Reproduce Click the link.

Expected behavior Link should go to documentation, and the codelab should be using an up to date target for building the Typescript protocol buffer library. I can look into what current typescript protobuff Bazel best practices are and try to have a PR with a fix next week.

Environment

tshaynik commented 2 years ago

27 provides the quick fix for the README, but we will still run into issues when upgrading rules_nodejs.

The ts_proto_library has been moved to https://www.npmjs.com/package/protoc-gen-ts The ts_library rule has also been moved into https://www.npmjs.com/package/@bazel/concatjs

I can try it out with a new version of rules_nodejs to see if it works with the new packages.