search

tweag / nix_bazel_codelab

Nix+Bazel Codelab
Apache License 2.0
50 stars 4 forks source link

Modernize and adopt bzlmod #55

Closed malt3 closed 4 months ago

malt3 commented 4 months ago

This modernizes the whole codelab.

I thought about splitting this PR to make it easier to digest, but this is not really possible since there are a lot of incompatibilities when upgrading from WORKSPACE rules to bzlmod.

Special thanks to @prednaz! You did a great job with this and I could pick up where you left it with ease.

Closes #49 Closes #54

malt3 commented 4 months ago

What is the general best practice around merging? Is a self-merge after approval generally acceptable?

aherrmann commented 4 months ago

What is the general best practice around merging? Is a self-merge after approval generally acceptable?

Yes, on some repositories (e.g. rules_nixpkgs, rules_haskell, ...) we have a merge queue set up. In those cases the right way to merge is to set the merge-queue label after your PR was approved by someone.

In this case we don't have a merge queue set up, so you can hit merge after the PR is approved and you've addressed all comments.