tweag / nixpkgs-graph-explorer

Explore the nixpkgs dependency graph
MIT License
15 stars 0 forks source link

Scaffolding client UI and server #5

Closed jeicher closed 2 years ago

jeicher commented 2 years ago

image This is just a basic Python UI client built with Flask that:

Selecting a node highlights the corresponding row on the table (and vice versa).

jeicher commented 2 years ago

image I thought something like this kind of behaviour might be helpful (perhaps in a directed graph)...

GuillaumeDesforges commented 2 years ago

I've participated to the PR, so asking someone else (e.g. @dorranh ) for review.

GuillaumeDesforges commented 2 years ago

This PR goes beyond the scope of just writing a query (#4) as it also

Let's try to make smaller PRs in the future :slightly_smiling_face:

jeicher commented 2 years ago

Very cool! In general looks good to me, just a couple of questions:

* What is the license for `line-chart.png`, do we need to include a reference to the image source somewhere (or did you make this?)?

* Is there a way to fetch the minified js libraries at build time rather than checking them into the repo?

Once the above are addressed I'm happy landing these changes

Good catches there :)

  1. That is actually a Flaticon image which is "Free for personal and commercial purpose with attribution.". The attribution involves including this on the site: Variable icons created by Pixel perfect - Flaticon . I've just replaced it with a similar but attribution-free version.

  2. I have moved all of the minified static things to CDN links.

dorranh commented 2 years ago

Perfect, thanks @jeicher!