tweag / nixpkgs-graph-explorer

Explore the nixpkgs dependency graph
MIT License
15 stars 0 forks source link

Add CI checks #61

Closed jlesquembre closed 1 year ago

jlesquembre commented 1 year ago

In my last PR, a small issue went unnoticed. I fixed it, and added some CI checks.

For now, only the frontend part is checked, we can add more checks in another PR.

Some additional changes I did, which are open to discussion:

jlesquembre commented 1 year ago

@dorranh makes sense, I didn't think the issue you mentioned. I'm reverting the python related changes. I agree with you about poetry2nix, but better to do those changes in a different PR

GuillaumeDesforges commented 1 year ago

Ideally we would want to run checks in the folder of each packages.

Maybe something like this could be done?

find . -name 'pyproject.toml' | xargs dirname | xargs -{} sh -c 'cd {} && black . && flake8 .'
jlesquembre commented 1 year ago

@GuillaumeDesforges That could be an option too. I probably tried to do too much on this PR, I'm reverting the python changes to focus only on the frontend part (which doesn't work on current main)