ghc-lib-parser 9.10 - Githubissues

amesgen commented 4 months ago

Update to ghc-lib-parser-9.10, build with GHC 9.10.1 in CI, drop GHC 9.4, update bounds.

See the changelog for details about the new syntactic features in GHC 9.10.
We can remove our HasSrcSpan in favor of ghc-lib-parser's HasLoc.
The EPA extension points in constructors do (usually) no longer contain the comments (they are now usually in the annotation part of a Located). We relied on this in p_if (as of #1092). Instead of laboriously passing the comments down from where we unwrap the LHsExpr, I added a new function getEnclosingComments to the R monad that leverages the comment stream, as that seemed much less invasive.
See the review comments for some further minor points.

github-actions[bot] commented 2 months ago

dpulls[bot] commented 1 month ago

:warning: Dpulls not installed on repository mrkkrp/path-io. Checkout our quickstart for how to install.

tchoutri commented 1 month ago

I'm very excited for this PR to land, I am starting a project with GHC 9.10. :)

tweag / ormolu