search

tweag / ormolu

A formatter for Haskell source code
https://ormolu-live.tweag.io
Other
956 stars 83 forks source link

Bump http-cache-semantics from 4.1.0 to 4.1.1 in /ormolu-live #989

Closed dependabot[bot] closed 1 year ago

dependabot[bot] commented 1 year ago

Bumps http-cache-semantics from 4.1.0 to 4.1.1.

Commits


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/tweag/ormolu/network/alerts).
amesgen commented 1 year ago

This seems to be due to this CVE: https://www.cve.org/CVERecord?id=CVE-2022-25881

IIUC, this shouldn't be relevant for us as we don't use JS to host an HTTP web server. Do we want to merge PRs like this one, or do we want to disable these automatic dependabot security updates?

mrkkrp commented 1 year ago

I think it creates noise and JS updates should be disabled. IIUC any JavaScript vulnerability in Ormolu Live is not the end of the world anyway, because it is completely client-side and there is virtually nothing to exploit in our case.

In general, security updates seems like a nice thing. I'm in favor of using it for non-JS things, maybe for GitHub actions. But from what I understand GitHub actions are going to be bumped regardless.

amesgen commented 1 year ago

Sounds good, closing this PR then :+1:

Do you have sufficient permissions to disable the Dependabot security updates as described here.

I'm in favor of using it for non-JS things, maybe for GitHub actions. But from what I understand GitHub actions are going to be bumped regardless.

Yes, that is configured in the dependabot.yml file: https://github.com/tweag/ormolu/blob/74762a98145ba3f62b48c95b70efe5fde93e8807/.github/dependabot.yml#L1-L6

dependabot[bot] commented 1 year ago

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

mrkkrp commented 1 year ago

Do you have sufficient permissions to disable the Dependabot security updates

I succeeded at disabling it :+1: