Improve fixity deduction

tweag / ormolu

A formatter for Haskell source code

https://ormolu-live.tweag.io

Other

950 stars 83 forks source link

Improve fixity deduction #994

Closed mrkkrp closed 1 year ago

mrkkrp commented 1 year ago

Close #892, close #929.

[x] Make CI pass
[x] How does Hoogle handle re-export of modules? (It doesn't, this is not ideal.)
[x] Test that it works for the new problematic cases
[x] Benchmark
[x] Add new tests
- [x] Make sure it works on regions
- [x] All different qualifications (+ combinations) in import sections
- [x] Check that overwrites work
- [x] What to do with hackage info spec? (Converted to Ormolu.FixitySpec.)

github-actions[bot] commented 1 year ago

🚀 Deployed on https://3aec9c2f4886edaffe6f18e789dce2481cd35765--ormolu-live.netlify.app

tbagrel1 commented 1 year ago

Looks very good to me in this current state, you adressed perfectly all my little remarks :)

amesgen commented 1 year ago

Ah, and regarding Ormolu Live: I will play around with whether making all dependencies available yields acceptable performance; alternatively, we can add a relevant input :+1: