search

tweag / pirouette

Language-generic workbench for building static analysis
MIT License
47 stars 2 forks source link

Add an `hlint` pre-commit hook and cleanup files accordingly #174

Closed Niols closed 1 year ago

Niols commented 1 year ago

closes #173

builds on top of #172

Now that I look at this, I am not convinced that we really want or need hlint. Maybe only for the unused pragmas?

gabrielhdt commented 1 year ago

I'd go with 3, which is the behaviour advised by HLint's developers:

Most hints are intended to be a good idea in most circumstances, but not universally - judgement is required.

(from https://hackage.haskell.org/package/hlint).

Niols commented 1 year ago

That sounds good to me but maybe we should ask the whole team what they think before taking such a decision.

Niols commented 1 year ago

Nah, let's not.