tweag / pirouette

Language-generic workbench for building static analysis
MIT License
47 stars 2 forks source link

Move or document orphan instances in `Language.Pirouette.QuasiQuoter.Internal` #176

Open Niols opened 1 year ago

Niols commented 1 year ago

The file src/Language/Pirouette/QuasiQuoter/Internal.hs includes orphan instances of Lift:

https://github.com/tweag/pirouette/blob/1bfaa872dc04654ad32e9f8e7e2420ec4fa6de3b/src/Language/Pirouette/QuasiQuoter/Internal.hs#L58-L88

I am not quite sure what they are for. Someone should look that up and either move them to a place that makes more sense (if possible), or at least document more what they are for, what types they should be attached to, and why we decided to have them as orphan.

cf also https://github.com/tweag/pirouette/pull/168#discussion_r1073869761