tweag / pirouette

Language-generic workbench for building static analysis
MIT License
47 stars 2 forks source link

Register the update to haskellNix in `sources.json` instead of hardcoding it in the nixfile #77

Closed VictorCMiraldo closed 2 years ago

VictorCMiraldo commented 2 years ago

This should have been a comment to #75 , by @serras, but I missed it when I first saw it. The more idiomatic way of updating a pinned dependency is using niv:

$ nix-shell -p niv --run "niv update haskellNix"

This will update the haskellNix version pinned in nix/sources.json for us

serras commented 2 years ago

I tried doing that by hand (updating the commit in the sources.json file), but it didn't work. This is why I ended up adding those lines in the shell.nix script.

serras commented 2 years ago

This business is hard :cry: Can I help somehow to get this to fruition?

VictorCMiraldo commented 2 years ago

@serras I don't think so; I think invalidating the cache was good, now we need to get the right dependencies in there

VictorCMiraldo commented 2 years ago

@serras! We did, it worked! I'll merge it in.