search

tweag / rules_nixpkgs

Rules for importing Nixpkgs packages into Bazel.
Apache License 2.0
294 stars 81 forks source link

Default value for `extra_flags_per_feature` CC configuration is invalid #578

Closed Silic0nS0ldier closed 2 months ago

Silic0nS0ldier commented 2 months ago

Describe the bug Bazel is expecting a dict ({}) but is given list ([]).

To Reproduce Use a Nix CC toolchain in Bazel 7.3.0 or 8.0.0-pre.20240807.1.

Expected behavior Build passes.

Environment

Additional context Issue manifests as

RROR: /[...]/external/local_config_cc_nix_x86_64-linux/BUILD.bazel:92:20: @@local_config_cc_nix_x86_64-linux//:local: expected value of type 'dict(string, list(string))' for attribute 'extra_flags_per_feature' in 'cc_toolchain_config' rule, but got [] (list)
ERROR: Evaluation of query "@local_config_cc_nix_x86_64-linux//:local" failed

Issue noted on #574, new issue raised as I cannot open the closed issue (and technically there is a value now).

aherrmann commented 2 months ago

Will be addressed by https://github.com/tweag/rules_nixpkgs/pull/576