search

tweag / rules_sh

Shell rules for Bazel
Apache License 2.0
42 stars 3 forks source link

Define bzl_library for rules_sh #11

Closed aherrmann closed 4 years ago

aherrmann commented 4 years ago

bzl_library target definitions are required to generate Stardoc documentation for any rules set that depends on rules_sh. This change is motivated by https://github.com/tweag/rules_haskell/pull/1244.

aherrmann commented 4 years ago

CI fails because the workers have been switched to NixOS. https://github.com/tweag/rules_sh/pull/12 should adapt rules_sh's CI.

aherrmann commented 4 years ago

@Mergifyio rebase

mergify[bot] commented 4 years ago

Command rebase: success

Branch has been successfully rebased

aherrmann commented 4 years ago

LGTM. But I'm a little confused about the use case for these targets.

They are required for Stardoc documentation of rulesets depending on rules_sh. E.g. for rules_haskell we need to depend on @rules_sh//sh:posix. If we don't then Stardoc fails with the following error

Stardoc documentation generation failed: File haskell/ghc_bindist.bzl imported '@rules_sh//sh:posix.bzl', yet external/rules_sh/sh/posix.bzl was not found, even at roots [., external/].