sh_posix_toolchain: reduce number of attributes by using attr.string_dict instead of attr.string list

tweag / rules_sh

Shell rules for Bazel

Apache License 2.0

42 stars 3 forks source link

sh_posix_toolchain: reduce number of attributes by using attr.string_dict instead of attr.string list #14

Closed smelc closed 4 years ago

smelc commented 4 years ago

This PR fixes #13

Tests

bazel test //...
bazel test //... in rules_nixpkgs with the appropriate patch: https://github.com/tweag/rules_nixpkgs/pull/117
bazel test //... test in rules_haskell by using rules_nixpkgs from the previous bullet

smelc commented 4 years ago

@aherrmann> Should we do a new release of rules_sh when this lands into master? So that, when merging the corresponding PR for rules_nixpkgs, we can make rules_nixpkgs depend on a released version of rules_sh?