search

tweag / rules_sh

Shell rules for Bazel
Apache License 2.0
42 stars 3 forks source link

Add a BCR test module #44

Closed z8v closed 1 year ago

z8v commented 1 year ago

Related issue: #41

z8v commented 1 year ago

Seems like the bzlmod version using 5.3.0 fails because the necessary extension that creates the remote_coverate_tools repository is not there, compared to v6.

I've tried manually updating the local extension to use the upstream version and loading it in the module.

    http_archive(
        name = "remote_coverage_tools",
        sha256 = "7006375f6756819b7013ca875eab70a541cf7d89142d9c511ed78ea4fefa38af",
        urls = [
            "https://mirror.bazel.build/bazel_coverage_output_generator/releases/coverage_output_generator-v2.6.zip",
        ],
    )

That didn't have any effect because the repo is called from a third party which doesn't have visibility on this override. Maybe there is a way to make it global?

Otherwise we might need to disable bzlmod tests for 5.x versions.

aherrmann commented 1 year ago

Otherwise we might need to disable bzlmod tests for 5.x versions.

I think that's fair. In Bazel v5 bzlmod was still experimental, it's only in general availability since v6.