tweag / rules_sh

Shell rules for Bazel
Apache License 2.0
42 stars 3 forks source link

Safer sh_posix_configure on Windows #7

Closed aherrmann closed 4 years ago

aherrmann commented 4 years ago

Autodetection using repository_ctx.which is not safe on Windows, as it may turn up false friends. E.g. Windows has a find.exe which is unrelated to POSIX find. Instead we follow the example of @bazel_tools//tools/sh:sh_configure.bzl and use tools next to bash.exe.

This repository currently doesn't have Windows CI. However, rules_haskell's CI passes with these changes.