search

tweag / simple-smt

BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Set up "Handle" design pattern #3

Closed gabrielhdt closed 1 year ago

gabrielhdt commented 1 year ago

This PR proposes to implement the "Handle" design pattern.

gabrielhdt commented 1 year ago

I also ran ormolu on the resulting file, which increases the diff. Let me know if someone prefers a minimised diff.

qaristote commented 1 year ago

Looking good, but I'd like to hold off on changing the API until we're sure of what we want.

Also, do you have any thoughts on whether Handle polymorphism should be used here as well ?

gabrielhdt commented 1 year ago

I agree we proabably don't need polymorphism in our case. I propose to close the pull request for now, and we'll reopen it when we discuss the API.