search

tweag / sparkle

Haskell on Apache Spark.
BSD 3-Clause "New" or "Revised" License
447 stars 30 forks source link

Add some interfaces using linear types to manage references safely #159

Closed facundominguez closed 3 years ago

buonuomo commented 3 years ago

@facundominguez Okay, I implemented many of the suggestions you gave above, including getting rid of many of the unnecessary files and simplifying the code in some places. At this point I'd consider this a more or less clean draft of the RDD / Context / Closure modules.

It's worth noting that the build is probably still failing due to this version depending on the yet-unmerged changes to jni that require extra imports for newLocalRef and deleteLocalRef to work.

facundominguez commented 3 years ago

It's worth noting that the build is probably still failing due to this version depending on the yet-unmerged changes to jni that require extra imports for newLocalRef and deleteLocalRef to work.

You could bring those changes by modifying the hash in https://github.com/tweag/sparkle/blob/master/WORKSPACE#L19

facundominguez commented 3 years ago

Looks good to me! Thanks @buonuomo!