Dependency updates and fixes

tweag / topiary

https://topiary.tweag.io/

MIT License

511 stars 17 forks source link

Dependency updates and fixes #685

Closed Xophmeister closed 4 months ago

Xophmeister commented 4 months ago

Updated to Rust 1.74, to maintain compatibility with newer dependencies
Pinned Tree-sitter to 0.20.10 and forced tree-sitter-json to the same to maintain API compatibility amongst all grammars
Pinned tree-sitter-rust to a known working rev
Pinned tree-sitter-nickel to rev with C-based scanner
Update wasm-bindgen to 0.2.91 (I'm not sure why this is needed, but it won't build without :shrug:)
Fixed PartialOrd implementation in the Tree-sitter facade

Xophmeister commented 4 months ago

nix -L flake check works on Linux. There is, however, a weird linker error on macOS, which needs to be investigated...

Edit Linker error fixed by moving to tree-sitter-nickel with C-based scanner.

torhovland commented 4 months ago

@Xophmeister The wasm-bindgen crate version needs to match the wasm-bindgen-cli tool, so I guess you needed to upgrade the crate because you upgraded the tool.

Xophmeister commented 4 months ago

Ah, right :ok_hand: Yes, that looks to be declared in default.nix, but it's not pinned to any nixpkg version.

yannham commented 4 months ago

@Xophmeister I haven't looked at your Nix config, but here is what we do to enforce that the versions stay in sync:

https://github.com/tweag/nickel/blob/20809d3161d9c0ba537d7bf871bd7684ef91b3f3/flake.nix#L84-L93

Xophmeister commented 4 months ago

Thanks, @yannham -- I will make an issue out of this so it isn't forgotten.