tweag / topiary

https://topiary.tweag.io/

MIT License

579 stars 29 forks source link

Output the (column, row) of a patternmatch when outputing at the INFO level #697

Closed ErinvanderVeen closed 7 months ago

ErinvanderVeen commented 7 months ago

Output the (column, row) of a patternmatch when outputing at the INFO level

Issue: #681

Description

This is part one of issue #681, adding the row and column to the debug output while not supporting named patterns yet.

Checklist

Checklist before merging:

[x] CHANGELOG.md updated
[x] README.md up-to-date

ErinvanderVeen commented 7 months ago

That said, this is recalculating the coords every time it spits out logging output, which is a lot. It would definitely be worth memoising pattern_position, if it's straightforward to do so.

Sure. Yeah. I'll do that!