search

tweag / webauthn

A library for parsing and validating webauthn/fido2 credentials
Apache License 2.0
34 stars 11 forks source link

Explicitly declare kinds, improve singleton instances #114

Closed lykahb closed 2 years ago

lykahb commented 2 years ago

The kind declarations are not necessary - GHC infers the kind like CeremonyKind using the local bindings under case. Declaring kind makes it easier to read the type signatures.

Also, I simplified a few places around the singleton logic and replaces instances created for the singleton constructors with the instances for the regular data type.

lykahb commented 2 years ago

@Infinisil Pushed the requested changes.