Drop dependency on deriving-aeson; update to Aeson 2

tweag / webauthn

A library for parsing and validating webauthn/fido2 credentials

Apache License 2.0

34 stars 11 forks source link

Drop dependency on deriving-aeson; update to Aeson 2 #115

Closed ErinvanderVeen closed 2 years ago

ErinvanderVeen commented 2 years ago

Dropping the deriving-aeson dependency keeps compilation times low enough, while still allowing the upgrade to Aeson 2.

Some changes were made to ensure compatibility with Aeson 1.x and 2.x.

Dropping the dependency was due to: https://github.com/fumieval/deriving-aeson/issues/16

Compilation times:

Master: 2m5.204s
Aeson 2.0: 6m31.963s
Aeson 2.0 without deriving-aeson: 2m2.934s

infinisil commented 2 years ago

Weird that CI doesn't run. We should definitely make that work since this PR requires compilation of a number of dependencies (with CI we'll have those in the cachix cache).

infinisil commented 2 years ago

A workaround to fix CI is to follow this guide to allow running a workflow manually for a branch.